Summary

• write-document's Gmail-attachment branch was gated on if (input.sourceEmailAttachment), which is truthy for { messageId: '', attachmentId: '' } , present but empty, not a real attachment request.
• Some tool-calling paths send exactly that empty shape on an ordinary document write with no attachment intent. That misrouted the write into the attachment-fetch branch, which failed with the unrelated error "No attachments found on that message", and the real content (e.g. a meeting-prep doc) never got saved.
• Confirmed against two real production executions (meeting-prep runs) that failed with this exact error on a plain document/upsert write with no attachment involved. The downstream effect: the doc write failing caused the dependent Slack notification to fail too, silently falling back to an email notification instead.
• Fix: gate on input.sourceEmailAttachment?.messageId so an empty/absent messageId is treated as no attachment request, and the write proceeds normally.

Test plan

• Added a regression test recreating the exact production shape (sourceEmailAttachment: { messageId: '', attachmentId: '' }) on a normal document/upsert write, asserting it now succeeds without touching the Gmail-attachment path
• pnpm --filter @zero/server exec vitest run src/mastra/tools/document/__tests__/writeDocumentTool.test.ts , 10/10 pass
• pnpm --filter @zero/server exec tsc --noEmit , clean for the changed file

🤖 Generated with Claude Code

https://claude.ai/code/session_01TQPx6BBWdyUWGF7YuvakuV

Greptile Summary

This PR makes ordinary document writes ignore an empty sourceEmailAttachment.messageId, preventing them from being misrouted through Gmail attachment retrieval.

• Changes the attachment branch guard to require a truthy message ID.
• Adds a regression test covering the observed empty attachment object and verifies that normal document persistence succeeds without Gmail calls.
• The regression test introduces type assertions that conflict with the repository’s explicit no-casts rule.

Confidence Score: 4/5

The behavioral fix appears sound, but the explicit repository requirement against type assertions must be satisfied before merging.

The changed runtime guard correctly handles the reported empty-string input, and the only accepted issue is the regression test’s use of prohibited casts.

Files Needing Attention: apps/server/src/mastra/tools/document/tests/writeDocumentTool.test.ts

Important Files Changed

### Issue 1
apps/server/src/mastra/tools/document/__tests__/writeDocumentTool.test.ts:333-335
**Test bypasses type checking**

The new regression test uses `as never` twice and asserts the result shape instead of deriving or validating the actual types. This violates the repository directive not to use casts to silence TypeScript errors. The repository requirement must be satisfied before merging by using typed test inputs and context and the inferred execute result.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

_{Reviews (1): Last reviewed commit: "fix(documents): ignore an empty sourceEm..." | Re-trigger Greptile}

Greptile also left 1 inline comment on this PR.