CedarCopilot wants to merge 1 commit into main from staging
Not deployed
Libra has no production signal for this change yet because it has not deployed. Libra checks hourly for 3 days after each deploy.
Unsafe to merge: the conversion metric returns an incorrect result for a supported history, and the repository-required fixture typing must be restored.
### Issue 1
apps/server/src/services/crm/deal-metrics.ts:455-461
A conversation that moves from a non-Deal AOP to an unbound AOP and then to Deals is recorded as unconverted. This loop only marks a conversion when one history entry directly changes from non-Deal to Deal, so valid multi-hop conversions deflate the reported conversion rate.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
### Issue 2
apps/server/src/trpc/routes/__tests__/crm-unlink-external-crm-filter.test.ts:19-62
These fixtures force values through `as unknown as IntegrationMetadata`, including the fixtures at lines 27, 35, 44, 53, and 62. This suppresses TypeScript's schema checking rather than making the test data conform to the metadata type, violating the repository directive against `as SomeType` casts. Define typed fixtures or validate the boundary instead; this repository requirement must be satisfied before merging.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Do not merge until the conversion calculation counts the multi-hop history and the test fixtures no longer use prohibited forced casts.
Reviews (1) · Last reviewed commit: "Merge pull request #2839 from CedarCopil..."
Libra has not measured any production surfaces for this change yet.